Despite Edinburgh’s cultural richness its retail portfolio has long been in the shadow of its neighbour Glasgow. Now an overhaul of its most unattractive scheme is set to give the city the offer it deserves. By Ben Cooper